Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Inconsistent behavior in Site List entries #12699

Open
3 tasks done
AliRezayiNejad opened this issue May 8, 2024 · 1 comment
Open
3 tasks done

[Bug] Inconsistent behavior in Site List entries #12699

AliRezayiNejad opened this issue May 8, 2024 · 1 comment
Labels

Comments

@AliRezayiNejad
Copy link

AliRezayiNejad commented May 8, 2024

Prerequisites

  • I searched for any existing report about this bug to avoid opening a duplicate.
  • I can reproduce this bug in a new, unmodified web browser profile with Dark Reader installed as the only extension.
  • I understand I need to use the Broken Website Report template if this bug I am reporting occurs on a single website.

Bug Description

(At least in "Invert listed only" mode,) Using *.example.com will affect www.example.com and any subdomains like sub1.example.com.
However, If a website omits the www. part from it's URL (like archlinux.org), then the *.example.com format does not affect the site, a separate entry of example.com must be created for that.
This behavior is consistent on Firefox on multiple platform.

Website Address

archlinux.org vs aur.archlinux.org or any other websites like it

Steps To Reproduce

  1. Switch to Invert listed only mode.
  2. Add a URL like *.archlinux.org and another website that does not omit "www." like *.darebee.com to the site list.
  3. Visit archlinux.org and darebee.com.

Expected Behavior

Either the main domain of both websites has to be affected by Dark Reader, or neither. I personally prefer both.

Actual Behavior

archlinux.org is not affected by Dark Reader, while darebee.com is.
This behavior is consistent for all similar websites, based on how they handle the "www." in their URL.

Screenshots

No response

Operating System

Windows 10, Arch Linux, Android

Web Browser name and version

Firefox 125.0.3

Dark Reader version

4.9.84

Additional Context

No response

@oberrich
Copy link
Contributor

oberrich commented May 9, 2024

I have investigated this issue and unless I am misunderstanding, this is intended and semantically correct.
In order to match both www.example.tld as well as example.tld you can simply use example.tld and it will handle both domains correctly.

  • Matching *.example.tld does
    • not match example.tld (imagine you have fixes for app.example.tld hosting an entirely different application).
    • match www.example.tld, which is semantically correct.
  • Matching example.tld captures both example.tld as well as www.example.tld.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants