Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up CI and create stable branch #175

Open
miketynes opened this issue Nov 12, 2021 · 1 comment
Open

Set up CI and create stable branch #175

miketynes opened this issue Nov 12, 2021 · 1 comment

Comments

@miketynes
Copy link
Collaborator

@jschrier has indicated that we can spend our way out of the CI problem, e.g circleCI, some other provider

@miketynes miketynes created this issue from a note in WF1 and WF3 deployment (To do) Nov 12, 2021
@vshekar
Copy link
Collaborator

vshekar commented Nov 15, 2021

As part of stabilizing the master branch we also need to

  1. Enforce a code style guide. I nominate black to do this. Most IDEs have plugins that autoformat to the style on save
  2. Logging: especially to log variables in code with frequent issues (For example robot file generation)
  3. Raise exceptions where appropriate. Recent example, I showed @nsmina914 to raise one if the phase data for a chemical is missing
  4. Separation of concerns. core.utilities has to be cleaned up so that functions are placed in the right place. Experiment create also does too many things and can be refactored.

Some of the above can be an issue on its own. For example I can take ownership of refactoring

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants