Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

material property vs action parameter: Val fields are inconsistent #107

Open
miketynes opened this issue Apr 19, 2021 · 3 comments
Open

Comments

@miketynes
Copy link
Collaborator

vw_material_property expects a val_val, but action parameter just a val

@miketynes
Copy link
Collaborator Author

Question from @vshekar: do we want property_x to have a generic foreign key?
Potential answer: no -- having one property_x minimizes effort from a psql implementation perspective but not from a django perspective. aside from minimizing effort, we cant think of any advantages

@miketynes miketynes changed the title Val fields are inconsistent materialpropert vs action parameter: Val fields are inconsistent Apr 19, 2021
@miketynes
Copy link
Collaborator Author

@miketynes miketynes changed the title materialpropert vs action parameter: Val fields are inconsistent material property vs action parameter: Val fields are inconsistent Apr 19, 2021
@miketynes
Copy link
Collaborator Author

New issue related to shekar's question: #108

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant