Implement MetadataViews And Core Views. #14
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@prpatel05 any update on this PR? With All Day now non-custodial, it would be nice for it to implement the NFT metadata standards linked here but seems like some TODOs are still remaining? |
|
Closing in favor of #16 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #11
This PR implements MetadataViews and all the Core Views for the
AllDayNFT. This change will allow AllDay to be onboarded to the NFT Catalog. Therefore allowing NFT interoperability and discoverability on-chain.Any of the Views can be changed to incorporate the correct/preferred information.
This change closely mirrors the implementation of MetadataViews from the
TopShotcontract -TODO
Before we can deploy this contract, there needs to be a way to fetch assets based on the NFT ID (and not the off-chain UUID). The proposal in this PR is to match what TopShot is doing (CloudFlare worker to translate the on-chain ID -> off-chain ID when pulling the asset). As part of this PR, we will finalize if this is the preferred option. If not, we can update this PR to implement the agreed upon method.