Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor mintMoment to use subedition #179

Open
jrkhan opened this issue Oct 27, 2022 · 0 comments
Open

Refactor mintMoment to use subedition #179

jrkhan opened this issue Oct 27, 2022 · 0 comments

Comments

@jrkhan
Copy link
Contributor

jrkhan commented Oct 27, 2022

Instructions

Refactor the existing minting method to be subedition aware, and remove the variant method added with the subedition feature branch.

Issue To Be Solved

Having a redundant minting method is confusing, and leaves a foot gun around in case one first mints moments with subeditions.

(Optional): Suggest A Solution

Steps to required deprecate/delete:

  1. Have NBA-API universally use the subedition minting method
  2. Refactor the initial minting method to be identical to the subedition minting method
  3. Have NBA-API universally use the initial minting method (that is now subedition aware)
  4. Remove the subedition minting method.

(Optional): Context

Flagged by @dete when reviewing the subedition change, and wanted to make sure it did not fall off the board.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant