Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include Play tagline/description on chain #167

Open
jrkhan opened this issue Oct 8, 2022 · 1 comment
Open

Include Play tagline/description on chain #167

jrkhan opened this issue Oct 8, 2022 · 1 comment
Labels
enhancement New feature or request foundations An issue that may be picked up by the DSS Foundations Pod

Comments

@jrkhan
Copy link
Contributor

jrkhan commented Oct 8, 2022

Issue To Be Solved

We will need to store the tagline/description for each play on chain in order to have parity with the Alchemy API used by Meta.

Example description:
"When the game is on the line, get the ball to your vet. Milwaukee Bucks guard Jrue Holiday attacks Memphis Grizzlies defender Dillon Brooks in the final seconds of a close March 4, 2021 ball game then steps back into a clutch mid-range jump shot to seal the victory."

Currently our on-chain descriptions are defined here:
https://github.com/dapperlabs/nba-smart-contracts/blob/master/contracts/TopShot.cdc#L607-L617

Open questions:

Should we create a new 'tagline' field/trait for this, or override our existing description field?
Should the map that stores the link between play id and tagline be defined in a ledger contract, or stored as a resource on a well known account?

@jrkhan jrkhan changed the title Include the play tagline/description on chain Include Play tagline/description on chain Oct 8, 2022
@jrkhan jrkhan added foundations An issue that may be picked up by the DSS Foundations Pod enhancement New feature or request labels Oct 8, 2022
@jrkhan
Copy link
Contributor Author

jrkhan commented Oct 11, 2022

Hey team! Please add your planning poker estimate with Zenhub @anatoly256 @naguigui @kurzenkov-globant

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request foundations An issue that may be picked up by the DSS Foundations Pod
Projects
None yet
Development

No branches or pull requests

1 participant