Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minting moments with a sub-edition #164

Open
jrkhan opened this issue Sep 22, 2022 · 1 comment
Open

Minting moments with a sub-edition #164

jrkhan opened this issue Sep 22, 2022 · 1 comment
Labels
enhancement New feature or request foundations An issue that may be picked up by the DSS Foundations Pod

Comments

@jrkhan
Copy link
Contributor

jrkhan commented Sep 22, 2022

Issue To Be Solved

We will need a way for newly minted Top Shot NFTs to have a subedition. The sub edition is intended to have it's own serial number range. (e.g. if we were to mint 100 moments total, the diamond sub edition will have serials 1-10, the golden sub edition would have serials 1 - 25, the base edition would have serials 1-65, the total edition size would need to be 100)
We will also need a way to store the subedition of each NFT (with all existing moments defaulting to the 'base edition' sub edition).

(Optional): Suggest A Solution

Potential solution for adding to the existing TopShot contract with the bulk of functionality living in a new contract:
https://sketchboard.me/rDsJU4sQGlN

Initial pass at minting sub editions with their own serial range has been added here:
#163

@jrkhan
Copy link
Contributor Author

jrkhan commented Sep 26, 2022

The initial pass at this has a second contract which manages the sub edition counts. It will also (as a ledger contract) store the mapping of the moment to the sub edition.

@jrkhan jrkhan mentioned this issue Oct 6, 2022
@jrkhan jrkhan added foundations An issue that may be picked up by the DSS Foundations Pod enhancement New feature or request labels Oct 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request foundations An issue that may be picked up by the DSS Foundations Pod
Projects
None yet
Development

No branches or pull requests

1 participant