Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TODO] evaluate if babel-traverse can be updated #1044

Open
mirabilos opened this issue Oct 18, 2023 · 2 comments
Open

[TODO] evaluate if babel-traverse can be updated #1044

mirabilos opened this issue Oct 18, 2023 · 2 comments

Comments

@mirabilos
Copy link
Collaborator

Dependabot filed https://github.com/danvk/dygraphs/security/dependabot/2 (which I don’t think is truly critical for Dygraphs right now as the code is not untrusted, AIUI), but we’ll want that to go away of course.

However, we had issues with 7.21.4 and up, so we will have to see whether these are fixed now.

Someone else opened babel/babel#15579 which was closed in the meantime, but I’m not sure how much of that even applies here. This needs investigation, so opening this “ticket” so I can do that later and have the info here.

@danvk
Copy link
Owner

danvk commented Oct 19, 2023

I wonder if we even need babel? dygraphs doesn't use many ES2015 features, and 2015 was a long time ago. Browser support for let/const/arrow functions is pretty solid these days.

@mirabilos
Copy link
Collaborator Author

mirabilos commented Oct 19, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants