Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

__gfx__ and __gff__ sections filled out unnecessarily #61

Open
benwiley4000 opened this issue May 26, 2019 · 1 comment
Open

__gfx__ and __gff__ sections filled out unnecessarily #61

benwiley4000 opened this issue May 26, 2019 · 1 comment

Comments

@benwiley4000
Copy link
Contributor

Seems like when to_lines is called for gfx and gff we end up with a bunch of empty data rows we don't need if those sections aren't full already. Not really the end of the world, but inflates the file size more than necessary.

I took a look at the code but wasn't able to quickly figure out why these sections behave differently than others.

@GiovanH
Copy link

GiovanH commented Oct 3, 2021

I'm not experiencing this issue with gfx after running luafmt. What command are you using that generates the extra output?

Experimenting a bit here, but obviously trimmed output doesn't match the expected test cases:
https://github.com/GiovanH/picotool/tree/no-trailing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants