Too fast bug

[bberthelemy]

When you swipe a lot of times in any direction quickly, the tiles go out the board !
And some blocks become unavailable ...

[danqing]

What's your iOS version, and how exactly to reproduce? Thanks!

[bberthelemy]

I tried it on the latest IOS release (8).

To reproduce the bug, just swipe to left, right, top or bottom a lot of time very fast.

De : Danqing Liu [mailto:notifications@github.com]
Envoyé : Friday, September 19, 2014 5:23 PM
À : ik/2048
Cc : bberthelemy
Objet : Re: [2048] Too fast bug (#8)

What's your iOS version, and how exactly to reproduce? Thanks!

—
Reply to this email directly or view it on GitHub #8 (comment) . https://github.com/notifications/beacon/8833935__eyJzY29wZSI6Ik5ld3NpZXM6QmVhY29uIiwiZXhwaXJlcyI6MTcyNjc1OTM5NCwiZGF0YSI6eyJpZCI6NDMwMDQxNjF9fQ==--4c9c70eb1ec7d39d546525ad259185497892cb2a.gif

[dingdaojun]

i found the bug too, compile with Xcode6 or run on iOS 8 device , it easily crashed. It seems to a SpritKit BUG.

[dingdaojun]

I found it is SHA 3ffec54 Fixed (I think) crash on iOS 8 problem...If I revert this commit, it 's not happen again

[danqing]

Yeah I saw the out-of-board thing. Haha it's actually pretty hilarious... I'm taking a look.

[danqing]

@dingdaojun Do you mean that commit causes crash, or causes the tiles to go out of board? I think without that change the app will crash on iOS 8.

[dingdaojun]

That commit causes the tiles to go out of board. But with the commit, it no longer crash on iOS 8. Thanks!

[dingdaojun]

iOS 8 crash is often EXC_BAD_ACCESS, isn't it? It's break on SpritKit and I don't know how to debug.

[danqing]

Okay yes. So that commit fixed EXC_BAD_ACCESS, but (possibly) introduced the out of board bug. I say possibly because it may already exist, just it would crash before it goes out

[dingdaojun]

Can you speak Chinese？I planned to use this open source game code to make an edition of "NBA 2048". Huh Huh, I found It crashed On iOS 8 so didn't commit to App Store yet. Because I don't know if Apple accept the app which only compatibly with iOS 7.

[dingdaojun]

Umm...But under iOS 8, I never see the out of board BUG. I have never used SpritKit yet before.

[danqing]

I know what's going wrong here, but you certainly don't plan for me to fix the bug so you can submit this to Apple as your app, do you?

[dingdaojun]

I certainly will submit app to App Store, but I will give the whole source code to you which I changed.

[dingdaojun]

If you can leave a contact such as IM or Email, we can send private message yet.

[bberthelemy]

@ik tell me what's wrong I could make a fix

[danqing]

@bberthelemy I'm looking and I'm not sure if there's a fix of < 10 lines. Basically runAction is (really) async in iOS 8, so we need to sync state updates to the visual movements.

What happens now is when you swipe fast, these two can go out of sync, and while the state tracker thinks a cell is at the first row, it may actually be at the 3rd row. Then you swipe down, and the state tracker moves the cell down by say 3 rows. Visually it will then be out of bound.

I wonder if moveTo instead of moveBy would prevent something like this to happen. If not, we need something that tracks all moving tiles and do things step by step, and that'd be a larger change.

[jaypak]

hi IK,

thank you for your work on writing this game using sprite kit

i found an issue relate to restart a new game while ago which cause memory leak?

i think you fix in this build

could you explain how you fix t? what was the issue? which part of code you updated?

thank you

jayp

[bberthelemy]

for the out of screen bug, just dont send all SKActions in the same time, i tryed to change every [_pendingActions addObject...]; by [self runAction...]; and it seems to work like that !! If you want me to update the code add me as contributor.

I hope it's helpfull.

[danqing]

@bberthelemy I wonder if that will have unexpected consequences.. Do you want to send a pull request? Thanks!

[danqing]

@jaypak Maybe this is what you are looking for?