Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throughput Unit #75

Open
willshen opened this issue May 10, 2022 · 0 comments
Open

Throughput Unit #75

willshen opened this issue May 10, 2022 · 0 comments
Assignees
@dwillcocks
Labels
bug Something isn't working

Comments

@willshen
Copy link

Describe the bug
starlink_dish_uplink_throughput_bytes and starlink_dish_downlink_throughput_bytes are calling API that returns unit in bits

Expected behavior
If we want to keep the same metric names, starlink_dish_uplink_throughput_bytes and starlink_dish_downlink_throughput_bytes, we probably should divide the return values from API by 8. Otherwise, we should consider renaming them to starlink_dish_uplink_throughput_bits and starlink_dish_downlink_throughput_bits
@willshen willshen added the bug Something isn't working label May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dwillcocks dwillcocks

Labels
bug Something isn't working
Milestone
No milestone
Development

No branches or pull requests
2 participants
@willshen @dwillcocks