Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fully deterministic runs #43

Open
jadkins99 opened this issue Apr 15, 2023 · 9 comments
Open

Fully deterministic runs #43

jadkins99 opened this issue Apr 15, 2023 · 9 comments

Comments

@jadkins99
Copy link

jadkins99 commented Apr 15, 2023

Awesome repo. quick question,

I ran the DMC WalkerWalk experiment 3 different times with the same seeds and got 3 different learning curves. How can I get reproducible experiments?Awesome repo. quick question,

I ran the DMC WalkerWalk experiment 3 different times with the same seeds and got 3 different learning curves. How can I get reproducible experiments?
curves
curves
curves

@danijar
Copy link
Owner

danijar commented Apr 16, 2023

Hi, are you asking for fully deterministic runs? I haven't paid much attention to this but I think the agent is already fully deterministic, so you'd probably just have to set the environment seed (make sure if you use more than 1 environment instance, that the environments have different seeds so they produce different data).

@danijar danijar changed the title Reprocibility Fully deterministic runs Apr 16, 2023
@jadkins99
Copy link
Author

Okay I will try that. Thank you for the quick response! What exactly is an "environment instance"? I couldn't find a clear definition in the paper.

@jadkins99
Copy link
Author

Also, how many seeds were the non-Minecraft experiments run for?

@subho406
Copy link

subho406 commented Apr 18, 2023

+1 on the question above. Maybe it's not that apparent in the paper, could you also provide some clarification on what the confidence intervals denote in the non-minecraft experiments (DMLab, DMC Proprio, Crafter, etc)? Is it std-error across multiple seeds, or std-error across a window of timesteps with a single seed, or something else?

@danijar
Copy link
Owner

danijar commented Apr 19, 2023

It's mean/std across seeds and at least 3 seeds per task, often more.

@jadkins99
Copy link
Author

jadkins99 commented Apr 25, 2023

Update: I seeded dmc_control here. And still got non-deterministic runs. Are there other non-environment sources of randomness not seeded?

@jadkins99
Copy link
Author

jadkins99 commented Apr 26, 2023

I found some non-seeded randomness in the repo. Namely here and here. Wouldn't these affect the agent?

@danijar
Copy link
Owner

danijar commented Apr 27, 2023

I don't think those two methods are run ever. Could you check e.g. by adding asdf to the two methods to see if it errors?

@swannercjj
Copy link

Seeding this it removes randomness from the first 1000 steps, but runs are non-deterministic afterwards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants