Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.1 compatibility #209

Open
Sweetchuck opened this issue Jan 2, 2022 · 7 comments
Open

PHP 8.1 compatibility #209

Sweetchuck opened this issue Jan 2, 2022 · 7 comments

Comments

@Sweetchuck
Copy link

Sweetchuck commented Jan 2, 2022

Deprecated: Return type of Stringy\Stringy::offsetSet($offset, $value) should either be compatible with ArrayAccess::offsetSet(mixed $offset, mixed $value): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /.../vendor/danielstjules/stringy/src/Stringy.php on line 893

The solution could be very similar to this: https://github.com/cebe/php-openapi/pull/143/files


Return type of Stringy\Stringy::count() should either be compatible with Countable::count(): int, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice.

@Sweetchuck
Copy link
Author

https://github.com/danielstjules/Stringy/network/dependents

  • 36,124 Repositories
  • 279 Packages

Last commit in 3.x (master) branch happened more than 4 years ago.

It is interesting that the PHP 8.1 compatibility issue just come up now.
Or do they know something that I don't know?

@Sweetchuck
Copy link
Author

PR will be coming soon. 🧑‍🏭

Sweetchuck added a commit to Sweetchuck/Stringy that referenced this issue Jan 3, 2022
@Sweetchuck
Copy link
Author

Sorry. I just noticed that there is an open PR which is related to PHP 8.1 compatibility. #208

Before I opened this issue, I had searched for an existing issue, but I forgot to look through the pull requests.

Sweetchuck added a commit to Sweetchuck/Stringy that referenced this issue Jan 3, 2022
Sweetchuck added a commit to Sweetchuck/Stringy that referenced this issue Jan 3, 2022
Sweetchuck added a commit to Sweetchuck/Stringy that referenced this issue Jan 9, 2022
Sweetchuck added a commit to Sweetchuck/Stringy that referenced this issue Jan 9, 2022
Sweetchuck added a commit to Sweetchuck/Stringy that referenced this issue Jan 9, 2022
Sweetchuck added a commit to Sweetchuck/Stringy that referenced this issue Jan 9, 2022
Sweetchuck added a commit to Sweetchuck/Stringy that referenced this issue Jan 9, 2022
Sweetchuck added a commit to Sweetchuck/Stringy that referenced this issue Jan 9, 2022
Sweetchuck added a commit to Sweetchuck/Stringy that referenced this issue Jan 9, 2022
Sweetchuck added a commit to Sweetchuck/Stringy that referenced this issue Jan 9, 2022
Sweetchuck added a commit to Sweetchuck/Stringy that referenced this issue Jan 9, 2022
Sweetchuck added a commit to Sweetchuck/Stringy that referenced this issue Jan 9, 2022
Sweetchuck added a commit to Sweetchuck/Stringy that referenced this issue Jan 9, 2022
Sweetchuck added a commit to Sweetchuck/Stringy that referenced this issue Jan 9, 2022
@Sweetchuck
Copy link
Author

Hello @danielstjules

A little attention here, please. 🙏

@noriellecruz
Copy link

noriellecruz commented May 8, 2022

It's funny to think such package still exist on packagist. Creating an open source library then suddenly ignoring it leaving thousands of projects broken and outdated lol.

@TCB13
Copy link
Contributor

TCB13 commented Aug 2, 2022

+1 on this !

@simogeo
Copy link

simogeo commented Aug 10, 2022

https://packagist.org/packages/voku/stringy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants