Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.5.0 from 3.4.0 introduced a regression in pan handling #4442

Closed
heumn opened this issue Aug 8, 2020 · 3 comments
Closed

3.5.0 from 3.4.0 introduced a regression in pan handling #4442

heumn opened this issue Aug 8, 2020 · 3 comments

Comments

@heumn
Copy link

heumn commented Aug 8, 2020

First of, thanks for an AWESOME library 馃殌

chartViewDidEndPanning is not being called in 3.5.0 after this change:

#4271

if anyone is interested, I am using this fork for now: atm-com@22e8eca from @tsorencraig

@nilnilnull
Copy link

Having the same issue with LineChartView's delegate (chartViewDidEndPanning not getting called).

@Archez
Copy link

Archez commented Sep 4, 2020

Would be nice to have a new delegate method to handle when highlight drag has ended or maybe add a new parameter to the existing chartViewDidEndPanning to differentiate which panning action happened.

@Donkov76
Copy link

Donkov76 commented Sep 4, 2020

Yes, a new delegate method, please!
Not nice but this "workaround" helped me:

let pan = lineChartView.gestureRecognizers?.first { $0 is UIPanGestureRecognizer } pan?.addTarget(self, action: #selector(gestureRecognized(_:)))

@objc func gestureRecognized(_ recognizer: UIPanGestureRecognizer) { if recognizer.state == .ended || recognizer.state == .cancelled { // Pan Ended } }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants