Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AContext parameter in TMVCController methods is redundant #562

Open
fastbike opened this issue Jun 15, 2022 · 1 comment
Open

AContext parameter in TMVCController methods is redundant #562

fastbike opened this issue Jun 15, 2022 · 1 comment
Assignees
Labels
accepted Issue has been accepted and inserted in a future milestone
Milestone

Comments

@fastbike
Copy link
Contributor

I've noticed two of the TMVCController class methods include AContext as a parameter.
procedure OnBeforeAction(AContext: TWebContext; const AActionName: string; var AHandled: Boolean); virtual;
procedure OnAfterAction(AContext: TWebContext; const AActionName: string); virtual;

Given that Context is available as a class property - is this now redundant ?
If it is, will removing this be too much of a breaking change ?

(originally created as part of #514 now split into separate issue)

@fastbike
Copy link
Contributor Author

@danieleteti

Yes the AContext param will be removed in 4.0.0-oxygen. It will break all the action filter methods, but a bit of cleaning is OK for a major version upgrade.

@danieleteti danieleteti added the accepted Issue has been accepted and inserted in a future milestone label Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Issue has been accepted and inserted in a future milestone
Projects
None yet
Development

No branches or pull requests

2 participants