Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decimal.compare is deprecated #50

Open
happysalada opened this issue Oct 29, 2020 · 2 comments
Open

Decimal.compare is deprecated #50

happysalada opened this issue Oct 29, 2020 · 2 comments
Labels
refactor

Comments

@happysalada
Copy link 

warning: Decimal.compare/2 is deprecated. Use Decimal.cmp/2 instead. This function will be re-introduced in Decimal v2.0 with new return value
lib/number/decimal.ex:11: Number.Decimal.compare/2

You can just replace it with Decimal.cmp/2

Let me know if anything doesn't make sense
@danielberkompas
Copy link
Owner

@happysalada this is already fixed in version 1.0.3.

@happysalada
Copy link
Author

happysalada commented Oct 31, 2020 •
edited

https://github.com/danielberkompas/number/blob/master/lib/number/decimal.ex#L11
It looks like it's still here on master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@danielberkompas @happysalada