Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If you use application config this library breaks in mix release on 1.9 #42

Open
Adzz opened this issue Jul 16, 2019 · 2 comments
Open
Labels

Comments

@Adzz
Copy link

Adzz commented Jul 16, 2019

I think it would be worth removing the ability to configure through Application config, as it should be discouraged (that's not what application config is for) and it currently wont work if you use mix releases in 1.9 because of this bug: elixir-lang/elixir#9225

I'd be happy to make a PR, would have to be a major update though, as it will be breaking for people who are using application config.

@danielberkompas
Copy link
Owner

How would you suggest doing config for a library like this? It doesn't seem like you should need to run a process in your supervision tree to be able to use a library like this.

@Adzz
Copy link
Author

Adzz commented Aug 1, 2019

I would suggest no config and have the config be runtime arguments or options to the given function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants