Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recommend GCM over CTR #98

Open
QuinnWilton opened this issue May 23, 2020 · 0 comments
Open

Recommend GCM over CTR #98

QuinnWilton opened this issue May 23, 2020 · 0 comments

Comments

@QuinnWilton
Copy link

It was pointed out to me that Cloak supports both GCM mode and CTR mode. Since GCM mode is the more secure choice of the two (CTR is unauthenticated, and thus susceptible to malleability attacks), I wonder if it's worth including a recommendation to use GCM mode in both this project, and cloak_ecto?

I understand that you're probably not in a position to remove CTR support, for backwards compatibility reasons, but how do you feel about logging deprecation warnings if you detect CTR being configured? Since Cloak makes it easy to re-encrypt data with a new cipher, I think you'd be able to provide a nice migration path toward people securing their data more effectively.

Either way, thanks for the great library :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants