Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implicit multiplication between numbers (hidden cdot) changes meaning of expression #135

Open
AlienKevin opened this issue Feb 24, 2019 · 1 comment · May be fixed by #156
Open

Implicit multiplication between numbers (hidden cdot) changes meaning of expression #135

AlienKevin opened this issue Feb 24, 2019 · 1 comment · May be fixed by #156

Comments

@AlienKevin
Copy link

I recently spotted a representation issue in guppy editor. When you import expressions from plain text, semantic latex, or JSON AST all results in auto-hiding of the multiplication dot between numbers. For example, the string import 3*10^8 produces a look of 310^8 in guppy when the import type is set to plain text or semantic latex. JSON AST also doesn't work because 3*10^8 generates ["*",[["val",[3]],["exponential",[["val",[10]],["val",[8]]]]]] and when I reimport this result back to guppy, the multiplication sign is again hidden. The only workaround now is to use XML as it does preserve the multiplication sign. I'd appreciate it if the multiplication sign is back :)

@JMSS-Unknown
Copy link
Contributor

A related issue can come up if you type 1+2^3 in the Guppy editor and then remove the + and move the cursor away as now the editor will show 12^3. The multiplication between the 1 and 2^3 is hidden. In this case the bracket around the 2 should be always forced as there is no explicit multiplication sign in front of it.

@JMSS-Unknown JMSS-Unknown linked a pull request Jun 3, 2019 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants