Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs about Environment Dependencies #273

Closed
hubertgrzeskowiak opened this issue Apr 8, 2024 · 3 comments
Closed

Docs about Environment Dependencies #273

hubertgrzeskowiak opened this issue Apr 8, 2024 · 3 comments

Comments

@hubertgrzeskowiak
Copy link

Hey, I just tried this in Docker using the Linux install script, and got surprised twice already. It looks like this tool depends on both NPM and a JDK, but I couldn't find anything mentioning this in the README or any other docs. Would you mind adding some docs saying which tools are expected and which versions are supported?

Cheers

@Vacxe
Copy link
Member

Vacxe commented Apr 8, 2024

Could you please describe your problem more detailed please?

Why did you used "Linux install script" in "Docker"?

  1. We providing docker image as well
  2. If you doing your own Docker image you can depend if from 1. or take a look on docker file
  3. Danger Kotlin is actually a "Bridge" for Danger JS, so, Danger JS required node, Kotlin is JVM type language. what required JDK.
  4. Using Linux Install Script is prefer if you want to install Danger Kotlin + Env Dependencies on host machine (like using brew on Mac), but for "In Docker" I'll recommend to take a look on the other solutions or 2.

Let me know if you have any questions

@hubertgrzeskowiak
Copy link
Author

Oh damn! I didn't realise there were Docker images ready! Cheers. Yeah, I overlooked it and tried to build my own

@Vacxe
Copy link
Member

Vacxe commented Apr 8, 2024

@hubertgrzeskowiak can you close this issue as well if problem is resolved, cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants