Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-normal image link formats are not recognized #159

Open
jinshuqishi2019 opened this issue Aug 4, 2023 · 2 comments
Open

Non-normal image link formats are not recognized #159

jinshuqishi2019 opened this issue Aug 4, 2023 · 2 comments
Labels
Bug Something isn't working

Comments

@jinshuqishi2019
Copy link

Environment

Operating System: Debian10
node --version:v18.17.0
npm --version: 9.6.7
percollate --version:v4.0.2

Description

Hello!
Now I want to generate epub from offline html for reading, one problem I found using this tool is that it can't handle this image format.

https://cubox.pro/c/filters:no_upscale()?valid=false&imageUrl=https%3A%2F%2Fpicx.zhimg.com%2F50%2Fv2-a6985ab263c4203730bb802c71b2dc90_720w.jpg%3Fsource%3D1940ef5c

Even if I use a command like this

percollate epub 1.html -o 1.epub --inline

What can I do to solve this problem to make it work

@danburzo danburzo added the Bug Something isn't working label Aug 4, 2023
@danburzo
Copy link
Owner

danburzo commented Aug 4, 2023

It seems at the moment we check the src of images to match a known image file extension, while the example image given above uses an image processing proxy, with the URL pathname as /c/filters:no_upscale(). Unfortunately, I can’t think of an easy user-level workaround for this...

@jinshuqishi2019
Copy link
Author

Thank you very much.
I solved the image problem by getting html to implement inline images with the help of single-file tool and then converted to epub using percollate. further multiple html can be converted into one epub to read as a book.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants