Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Inconsistency between documentation and code sample for Code flow PKCE auto-login #1927

Open
lufo88ita opened this issue Apr 22, 2024 · 0 comments

Comments

@lufo88ita
Copy link

Version

17.0.0

Please provide a link to a minimal reproduction of the bug

No response

Please provide the exception or error you saw

I'm reading the documentation here
https://angular-auth-oidc-client.com/docs/documentation/auto-login
It is written 
"You have to call checkAuth() in this CallbackComponent so that the url can be processed and set up, then redirect. Also think of calling checkAuth() in the AppComponent"
But in the code sample of Code flow PKCE auto-login
https://github.com/damienbod/angular-auth-oidc-client/tree/main/projects/sample-code-flow-auto-login-all-routes
the callback component
https://github.com/damienbod/angular-auth-oidc-client/blob/main/projects/sample-code-flow-auto-login-all-routes/src/app/callback/callback.component.ts
seems do nothing. There is a comment about business logic, but no checkAuth() at all.

Steps to reproduce the behavior

Just check the documentation of auto-login and the relative sample code

A clear and concise description of what you expected to happen.

No response

Additional context

I try to add the checkauth() in my callback implementation but it generate a loop and then an error, so I try to remove it and now I have problem with the refresh token: it said there is no refresh token, but a refresh (F5) seems to fix all. Can you fix or explain the discrepancy?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant