Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storybook Color Readability Issues #27

Closed
benjitrosch opened this issue Mar 12, 2022 · 1 comment
Closed

Storybook Color Readability Issues #27

benjitrosch opened this issue Mar 12, 2022 · 1 comment
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers

Comments

@benjitrosch
Copy link
Collaborator

Many of the Storybook stories feature components without backgrounds and the readability is very low. For example, our Collapse component:

Screen Shot 2022-03-12 at 1 33 40 PM

Here's how the Collapse component (and all components) are displayed on the daisyUI site:

Screen Shot 2022-03-12 at 1 34 09 PM

Readability seems generally better because the component itself is wrapped in the preview grid. I think it would be a good idea to wrap existing stories in a similar container to help clarify the distinction between components and the background.

@benjitrosch benjitrosch added documentation Improvements or additions to documentation good first issue Good for newcomers labels Mar 12, 2022
@benjitrosch
Copy link
Collaborator Author

This issue has been resolved with #87

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant