Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Input.tsx #102

Merged
merged 1 commit into from Apr 25, 2022
Merged

Update Input.tsx #102

merged 1 commit into from Apr 25, 2022

Conversation

mikeyGlitz
Copy link
Contributor

This change addresses the feature requested in #101 where the IDE presents a type attribute for Input, however whenever an Input is rendered, its type attribute will always be text.

Further recommendations would be to implement a custom type where a limited selection of "types" may be selected for input
i.e.

type: 'date' | 'email' | 'file' | 'image' | 'month' | 'pattern' | 'password' |  'number' | 'tel' | 'text

The point being her would be to remove types like checkbox and button from the list of selectable "inputs" since they're already covered by other components.

Add type parameter from `input` properties -- type
@netlify
Copy link

netlify bot commented Apr 24, 2022

Deploy Preview for react-daisyui ready!

Name Link
🔨 Latest commit 86521d5
🔍 Latest deploy log https://app.netlify.com/sites/react-daisyui/deploys/6265d3cf8292dc0009a433b7
😎 Deploy Preview https://deploy-preview-102--react-daisyui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@benjitrosch
Copy link
Collaborator

Good catch, thanks for finding this @mikeyGlitz!

I don't mind having all types available even though they're already covered. That way users have the option to use for everything and ignore the other components.

@benjitrosch benjitrosch merged commit 7e6b53b into daisyui:main Apr 25, 2022
This was referenced Jun 30, 2022
This was referenced Aug 16, 2022
This was referenced Sep 5, 2022
This was referenced Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants