fix: removed hardcoded children props

CHANGELOG.md

@@ -1,5 +1,12 @@
 # Changelog
 
+### [1.7.5](https://www.github.com/daisyui/react-daisyui/compare/v1.7.4...v1.7.5) (2022-04-05)
+
+
+### Bug Fixes
+
+* removed polymorphic typing from types.ts ([0000986](https://www.github.com/daisyui/react-daisyui/commit/00009869c60c0752817bbaf8f2d90c434784753e))
+
 ### [1.7.4](https://www.github.com/daisyui/react-daisyui/compare/v1.7.3...v1.7.4) (2022-04-05)
 
 

package.json

@@ -1,6 +1,6 @@
 {
   "name": "react-daisyui",
-  "version": "1.7.4",
+  "version": "1.7.5",
   "description": "react-daisyui - DaisyUI components built with React 🌼",
   "author": "daisyui",
   "license": "MIT",

src/Alert/Alert.tsx

@@ -6,7 +6,6 @@ import { IComponentBaseProps, ComponentStatus } from '../types'
 
 export type AlertProps = React.HTMLAttributes<HTMLDivElement> &
   IComponentBaseProps & {
-    children?: ReactNode | ReactNode[]
     icon?: ReactNode
     status?: ComponentStatus
   }

src/Artboard/Artboard.tsx

@@ -1,12 +1,11 @@
-import React, { forwardRef, ReactNode } from 'react'
+import React, { forwardRef } from 'react'
 import clsx from 'clsx'
 import { twMerge } from 'tailwind-merge'
 
 import { IComponentBaseProps } from '../types'
 
 export type ArtboardProps = React.HTMLAttributes<HTMLDivElement> &
   IComponentBaseProps & {
-    children?: ReactNode | ReactNode[]
     size?: 1 | 2 | 3 | 4 | 5 | 6
     horizontal?: boolean
   }

src/Divider/Divider.tsx

@@ -6,7 +6,6 @@ import { IComponentBaseProps } from '../types'
 
 export type DividerProps = React.HTMLAttributes<HTMLDivElement> &
   IComponentBaseProps & {
-    children?: string
     vertical?: boolean
   }
 

src/Link/Link.tsx

@@ -6,8 +6,6 @@ import { IComponentBaseProps, ComponentColor } from '../types'
 
 export type LinkProps = React.AnchorHTMLAttributes<HTMLAnchorElement> &
   IComponentBaseProps & {
-    children: string
-    href?: string
     color?: 'neutral' | ComponentColor
     hover?: boolean
   }

src/Modal/Modal.tsx

@@ -13,7 +13,6 @@ export type ModalRef = {
 
 export type ModalProps = React.HTMLAttributes<HTMLDivElement> &
   IComponentBaseProps & {
-    children?: ReactNode | ReactNode[]
     open?: boolean
     title?: string
     footer?: boolean

src/Tabs/Tab.tsx

@@ -1,25 +1,19 @@
-import React, { ReactNode } from 'react'
+import React from 'react'
 import clsx from 'clsx'
 import { twMerge } from 'tailwind-merge'
 
 import { ComponentSize } from '../types'
 
-export type TabProps<T> = {
-  children?: ReactNode | ReactNode[]
+export type TabProps<T> = React.AnchorHTMLAttributes<HTMLAnchorElement> & {
   value: T
   activeValue?: T
   onClick?: (value: T) => void
   size?: ComponentSize
   variant?: 'bordered' | 'lifted'
-  className?: string
-  style?: Record<string, string | number>
 }
 
 const TabInner = <T extends string | number | undefined>(
-  props: TabProps<T>,
-  ref?: React.ForwardedRef<T>
-): JSX.Element => {
-  const {
+  {
     children,
     value,
     activeValue,
@@ -28,9 +22,10 @@ const TabInner = <T extends string | number | undefined>(
     variant,
     className,
     style,
-    ...rest
-  } = props
-
+    ...props
+  }: TabProps<T>,
+  ref?: React.ForwardedRef<T>
+): JSX.Element => {
   const classes = twMerge(
     'tab',
     className,
@@ -44,7 +39,7 @@ const TabInner = <T extends string | number | undefined>(
   return (
     <a
       role="tab"
-      {...rest}
+      {...props}
       className={classes}
       style={style}
       onClick={() => onClick && onClick(value)}