Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate build of Docker images #203

Open
josteinaj opened this issue Mar 31, 2022 · 11 comments
Open

Automate build of Docker images #203

josteinaj opened this issue Mar 31, 2022 · 11 comments
Assignees

Comments

@josteinaj
Copy link
Member

https://hub.docker.com/r/daisyorg/pipeline-assembly/tags

@bertfrees
Copy link
Member

I used to do this by building the image and pushing it to Hub, but it's not working anymore :-( You don't happen to have an idea?

@josteinaj
Copy link
Member Author

josteinaj commented Mar 31, 2022

I have all of NLBs docker images set up to trigger a new build on every new commits on the master branch as well as any tags matching a certain pattern. That could be an option for daisyorg/pipeline-assembly as well so that you don't have to do it manually; maybe with a -DskipTests or similar if the tests either don't work or take too long on docker hub.

Occasionally I do tag things locally and push it to docker hub, and it worked fine the last time I tried. What happens when you try to build, tag and push?

@bertfrees
Copy link
Member

bertfrees commented Mar 31, 2022

I have all of NLBs docker images set up to trigger a new build on every new commits on the master branch as well as any tags matching a certain pattern.

That is how it used to work if I remember correctly, but then that stopped working and I started to build the images locally and push them. I'd love it to be done automatically again.

What happens when you try to build, tag and push?

Everything seemed normal but the new tags wouldn't appear on https://hub.docker.com/r/daisyorg/pipeline-assembly/tags. But I tried again now and now it worked :-)

By the way you'll find v1.14.6, which is now the latest version. I haven't pushed v1.14.5.

@josteinaj
Copy link
Member Author

docker build . didn't work in the pipeline-assembly repo for me. This is the error when I'm on the tag v1.14.6:

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-assembly-plugin:2.6:single (assemble-linux-dir) on project assembly: Failed to create assembly: Error adding file to archive: /usr/src/daisy-pipeline2/target/release-descriptor/releaseDescriptor.xml -> [Help 1]

In the daisyorg organization on docker hub, under the "Builds" tab, I get a message saying "Available with Pro, Team and Business subscriptions." So probably, DAISY needs to upgrade to a Team subscription to get automated builds working again. It would be $300 per year.

@bertfrees
Copy link
Member

docker build . didn't work in the pipeline-assembly repo for me.

I don't normally use that to build the docker image. But I made some commits last week that should fix it I think. I've just pushed them to the "develop" branch.

@josteinaj
Copy link
Member Author

/bin/sh: 1: make: not found

@bertfrees
Copy link
Member

Hehe, great. Needs some debugging :-)

@josteinaj
Copy link
Member Author

😉

@bertfrees
Copy link
Member

Updated the "develop" branch with some more fixes.

@josteinaj
Copy link
Member Author

Seems to work! Nice!

@bertfrees bertfrees changed the title Missing Docker image for Pipeline 2 v1.14.5 Automate build of Docker images Apr 7, 2022
@bertfrees
Copy link
Member

I added a Github workflow to build and push a Docker image of the master branch to daisyorg/pipeline:latest-snapshot: daisy/pipeline@f16b64f. I still do the releases manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants