Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase or remove default JAVA_MAX_MEM #145

Open
josteinaj opened this issue Nov 23, 2017 · 1 comment
Open

Increase or remove default JAVA_MAX_MEM #145

josteinaj opened this issue Nov 23, 2017 · 1 comment

Comments

@josteinaj
Copy link
Member

josteinaj commented Nov 23, 2017

It's currently set to 1G. Could we increase it to maybe 4G? Or if we just remove it, I think the system will pick a good default for us? My computer has 32 GB of RAM, and according to java -XX:+PrintFlagsFinal -version | grep HeapSize my max java memory defaults to 8G.

@bertfrees
Copy link
Member

OK maybe it's best to just remove the default then. There's indeed not much point in setting it to a value lower than the default. Possibly we could generate a warning when a value is specified and it is less than 1G?

By the way, related: we should probably remove the $JAVA_MAX_PERM_MEM variable because the -XX:MaxPermSize has been removed in Java 8 which is our minimal Java requirement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants