Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename current release descriptor to latest? #123

Open
2 of 4 tasks
bertfrees opened this issue Jan 23, 2017 · 1 comment
Open
2 of 4 tasks

Rename current release descriptor to latest? #123

bertfrees opened this issue Jan 23, 2017 · 1 comment

Comments

@bertfrees
Copy link
Member

bertfrees commented Jan 23, 2017

The reason Javi added "current" was because:

Apparently latest has some kind of special meaning for github pages, and will not allow accessing resources that name, thus the current key word.

However accessing https://daisy.github.io/pipeline-assembly/releases/latest seems to work fine. Anyway, either "latest" or "current" should be removed to avoid confusion.

To do:

  • Change default version in pipeline-updater
  • Change value of "version" argument passed to the updater by updater-wrapper
  • Rename files on http://daisy.github.io/pipeline-assembly (temporarily) and test
    • or possibly we can create an automatic test for this using a mock service (Docker?)
  • Undo renaming of files until release has been made with new updater/updater-wrapper
@rdeltour rdeltour changed the title Remove "latest" or "current" from daisy.github.io/pipeline-assembly/releases Rename current release descriptor to latest? Feb 1, 2017
@rdeltour
Copy link
Member

rdeltour commented Feb 1, 2017

I removed the latest descriptor, which wasn't used. Both @bertfrees and I agree that latest is more explicit than current though, so we should consider whether renaming is easy (the keyword is hardcoded in the descriptor, so the updater would need to be updated itself).

@bertfrees bertfrees added this to the August 2017 milestone Aug 1, 2017
@rdeltour rdeltour removed this from the August 2017 milestone Aug 15, 2017
bertfrees added a commit to daisy/pipeline-updater that referenced this issue Aug 31, 2017
bertfrees added a commit to daisy/pipeline-framework that referenced this issue Aug 31, 2017
@bertfrees bertfrees self-assigned this Sep 1, 2017
bertfrees added a commit to daisy/pipeline-framework that referenced this issue Sep 28, 2018
bertfrees added a commit to daisy/pipeline-updater that referenced this issue Sep 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants