-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
binaryPGLMM #28
Comments
Hi Tony, I just made pglmm as an alias for communityPGLMM. Can we think another name for binaryPGLMM? Maybe something like pglm? Best, |
Daijiang,
Great. I’ll update the R version in rr2. As for names, I’d forgotten about pglmm for communityPGLMM. Maybe discretePGLMM. What do you think?
This did make me think about pglmm again. For that name, it probably does make sense to have it set up in a form where, at least for the long form specification, the factors don’t need to be called sp and site.
Cheers, Tony
From: Daijiang Li <notifications@github.com>
Reply-To: daijiang/phyr <reply@reply.github.com>
Date: Sunday, October 7, 2018 at 10:12 AM
To: daijiang/phyr <phyr@noreply.github.com>
Cc: "Anthony R. Ives" <arives@wisc.edu>, Author <author@noreply.github.com>
Subject: Re: [daijiang/phyr] binaryPGLMM (#28)
Hi Tony,
It would be great to update the version in rr2 first, then I can update phyr accordingly. Plus, the c++ part of binaryPGLMM does not take effect yet.
I just made pglmm as an alias for communityPGLMM. Can we think another name for binaryPGLMM? Maybe something like pglm?
Best,
Daijiang
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#28 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ALF_LFftbwMVjRDvXURrFZjmnzl3ARzGks5uihnHgaJpZM4XLx0L>.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I figure we should update binaryPGLMM to do family=binomial and poisson. Should we change the name? This has the advantage of differentiating it from binaryPGLMM in ape, which we've talked about. How about calling it PGLMM?
I can also update rr2 to swap binaryPGLMM for PGLMM. But should I include a version of PGLMM in rr2 because rr2 will likely precede phyr? PGLMM is more complicated than rr2, which doesn't involve C++. I could just put the R version of PGLMM on rr2.
Thoughts?
The text was updated successfully, but these errors were encountered: