Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

binaryPGLMM #28

Open
arives opened this issue Oct 7, 2018 · 2 comments
Open

binaryPGLMM #28

arives opened this issue Oct 7, 2018 · 2 comments

Comments

@arives
Copy link
Collaborator

arives commented Oct 7, 2018

I figure we should update binaryPGLMM to do family=binomial and poisson. Should we change the name? This has the advantage of differentiating it from binaryPGLMM in ape, which we've talked about. How about calling it PGLMM?

I can also update rr2 to swap binaryPGLMM for PGLMM. But should I include a version of PGLMM in rr2 because rr2 will likely precede phyr? PGLMM is more complicated than rr2, which doesn't involve C++. I could just put the R version of PGLMM on rr2.

Thoughts?

@daijiang
Copy link
Owner

daijiang commented Oct 7, 2018

Hi Tony,
It would be great to update the version in rr2 first, then I can update phyr accordingly. Plus, the c++ part of binaryPGLMM does not take effect yet.

I just made pglmm as an alias for communityPGLMM. Can we think another name for binaryPGLMM? Maybe something like pglm?

Best,
Daijiang

@arives
Copy link
Collaborator Author

arives commented Oct 7, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants