Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

communityPGLMM.plot.random.effects doesn't work well #20

Open
arives opened this issue Apr 6, 2018 · 2 comments
Open

communityPGLMM.plot.random.effects doesn't work well #20

arives opened this issue Apr 6, 2018 · 2 comments

Comments

@arives
Copy link
Collaborator

arives commented Apr 6, 2018

When you have a lot of matrices, all the plotting region is filled by the legend bar. I suggest going back to using image() [since I never found a way to remove the legend bar in lattice]. And I don't like color.

Also, I liked the name communityPGLMM.plot.re as shorter. In fact, we could even shorten communityPGLMM to comPGLMM. That might be a nice way to distinguish it form the version in pez. Right now, the new version is pretty different.

@daijiang
Copy link
Owner

daijiang commented Apr 6, 2018

Tony,
To suppress the legend bar, set colorkey = FALSE. The nice thing about lattice and ggplot2 is that it will be so much easier to combine and custom plots later... In terms of color, I think you can use col.regions argument to use your own color scheme.

I can change the function name to communityPGLMM.plot.re.

The main reason I still used communityPGLMM is to be able to be compatible with pez. If we decide to short the name, I would go further and use something like cPGLMM or just PGLMM.

@daijiang
Copy link
Owner

@arives now both communityPGLMM.plot.re and communityPGLMM.show.re available in phyr. plot.communityPGLMM will plot observed values, and optionally predicted values (predicted = FALSE by default).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants