Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect export string generation #1891

Open
StarryWisdom opened this issue Feb 6, 2023 · 0 comments · May be fixed by #1900
Open

Incorrect export string generation #1891

StarryWisdom opened this issue Feb 6, 2023 · 0 comments · May be fixed by #1900

Comments

@StarryWisdom
Copy link
Contributor

If a ship has its reverse impulse speed then when export to clipboard is used it will export with "setImpulseMaxReverseSpeed" (an undefined lua function) rather than using setImpulseMaxSpeed with 2 parameters

Presumibly the issue is here

EmptyEpsilon/src/spaceObjects/spaceship.cpp

Line 1766 in 3489f30

ret += ":setImpulseMaxReverseSpeed(" + string(impulse_max_reverse_speed, 1) + ")";
, and will be an easy fix
oznogon added a commit to oznogon/EmptyEpsilon that referenced this issue Feb 20, 2023
@oznogon
[SpaceShip] Update beam export strings, add scripting functions
67f8b2b 
- Adds SpaceShip:getBeamWeaponDamageType(),
  SpaceShip:getBeamWeaponTexture() scripting functions
- Handles impulse_max_reverse_speed in setImpulseMaxSpeed exports
  (fixes daid#1891)
- Adds setAcceleration export
- Splits setBeamWeapon and setBeamWeaponTurret export conditions
- Adds setBeamWeaponTexture, setBeamWeaponEnergyPerFire,
  setBeamWeaponHeatPerFire, and setBeamWeaponDamageType exports
@oznogon oznogon linked a pull request Feb 20, 2023 that will close this issue
Open
oznogon added a commit to oznogon/EmptyEpsilon that referenced this issue Mar 19, 2023
@oznogon
[SpaceShip] Update beam export strings, add scripting functions
fb9ca88 
- Adds SpaceShip:getBeamWeaponDamageType(),
  SpaceShip:getBeamWeaponTexture() scripting functions
- Handles impulse_max_reverse_speed in setImpulseMaxSpeed exports
  (fixes daid#1891)
- Adds setAcceleration export
- Splits setBeamWeapon and setBeamWeaponTurret export conditions
- Adds setBeamWeaponTexture, setBeamWeaponEnergyPerFire,
  setBeamWeaponHeatPerFire, and setBeamWeaponDamageType exports
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[SpaceShip] Update beam export strings, add scripting functions oznogon/EmptyEpsilon
1 participant
@StarryWisdom