New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WriteRegU16LE typo #20

Open

amurchick opened this issue Dec 27, 2022 · 1 comment · May be fixed by #22

amurchick commented Dec 27, 2022 •

edited

Please fix typo

Now in https://github.com/d2r2/go-i2c/blob/master/i2c.go#L209 was * instead of &

w := (value*0xFF00)>>8 + value<<8

Fixed line:

w := (value&0xFF00)>>8 + value<<8

But this variant more correct:

w := (value>>8)|(value<<8)

The text was updated successfully, but these errors were encountered:

Author

amurchick commented Dec 28, 2022

Same issue also at line https://github.com/d2r2/go-i2c/blob/master/i2c.go#L231

Volcore linked a pull request

that will close this issue

Fixed bitmasking issue writing 16 bit low endian integers #22

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment