Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cookie.SetDomain() failed, invalid domain: {0} #644

Open
wangdongdong520 opened this issue May 12, 2022 · 2 comments
Open

Cookie.SetDomain() failed, invalid domain: {0} #644

wangdongdong520 opened this issue May 12, 2022 · 2 comments

Comments

@wangdongdong520
Copy link

wangdongdong520 commented May 12, 2022

when i upgrade cefpython3==66.1 , then i find SetDomain error with “Cookie.SetDomain() failed, invalid domain: {0}”。so you add regexp test domin is right,but regexp is not perfect 。 It shouldn't be /^(?:a-z0-9?.)[a-z0-9][a-z0-9-_]{0,61}[a-z]$/ it should support IP

@cztomczak
Copy link
Owner

Can you send a pull request? Thank you.

@wangdongdong520
Copy link
Author

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants