Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tool icons on the top-right #266

Open
13 of 15 tasks
maxkfranz opened this issue Mar 7, 2024 · 4 comments
Open
13 of 15 tasks

Tool icons on the top-right #266

maxkfranz opened this issue Mar 7, 2024 · 4 comments
Assignees
Labels
high priority The top things to do

Comments

@maxkfranz
Copy link
Member

maxkfranz commented Mar 7, 2024

Description of new feature

  • Two icons should always be visible: shift/box select and download. The rest can just go in the hamburger menu all the time.
  • New list of icons / tools in the hamburger:
  • Download icon should be a line with an arrow
  • Same icon for download gene list
  • It needs to be clear in the tooltip for the main download what you get: Download
  • The one download option downloads everything -- the enrichment files and the images in one ZIP

Motivation for new feature

  • There are a lot of icons, and it's difficult to find the important ones, like download.
@maxkfranz maxkfranz added the high priority The top things to do label Mar 7, 2024
@chrtannus chrtannus self-assigned this Mar 11, 2024
chrtannus added a commit that referenced this issue Mar 11, 2024
chrtannus added a commit that referenced this issue Mar 11, 2024
- Download button now downloads everything (enrichment data and images) in one ZIP.
- Using a new "Share" icon.
-- #266
chrtannus added a commit that referenced this issue Mar 11, 2024
chrtannus added a commit that referenced this issue Mar 13, 2024
…owing other icons (i.e. not on 'mobile' screen) -- #266
@chrtannus
Copy link
Member

This is how the toolbar looks now when shift-select and download are visible but the other ones are in the overflow menu:

overflow-menu

(*) Notice that I'm suggesting we use the more standard vertical ellipsis icon in this scenario, instead of the hamburger one, which is more associated with a mobile device's menu and usually contains all the other menu/toolbar options. I just find that the hamburger icon would not stand out as much here.


This is how it look on small screens (mobile):

mobile-menu

(*) I suggest we hide all the toolbar icons in this scenario--the screen is just too small--and that we use the hamburger icon.

chrtannus added a commit that referenced this issue Mar 13, 2024
…ore Network Layout" (too long for the mobile menu after the previous changes) -- #266
@chrtannus
Copy link
Member

The mobile/overflow menu now renders toggleable items properly:

toggleable-menu-item

@mikekucera
Copy link
Contributor

looks good

chrtannus added a commit that referenced this issue May 9, 2024
@chrtannus
Copy link
Member

toolbar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
high priority The top things to do
Projects
None yet
Development

No branches or pull requests

3 participants