concentric layout: controlling node level from ipycytoscape

[shadiakiki1986]

Current (buggy) behaviour

concentric layout: node levels are controlled from a javascript function through argument named "concentric"
(docs at: https://js.cytoscape.org/#layouts/concentric )

Desired behaviour

This default function would check for a field in node data first, in case it is set from ipycytoscape, before falling back to using node degrees. ipycytoscape cannot send a javascript function to the front-end since ipywidgets/traitlets json-serializes all data sent to the front-end.

Minimum steps to reproduce

Check issue in ipycytoscape: cytoscape/ipycytoscape#238 (comment)

[maxkfranz]

This sounds like an ipycytoscape issue. Have you tried posting your issue there?

…

On Nov 5, 2021, at 6:18 PM, Shadi Akiki ***@***.***> wrote: Current (buggy) behaviour concentric layout: node levels are controlled from a javascript function through argument named "concentric" (docs at: https://js.cytoscape.org/#layouts/concentric <https://js.cytoscape.org/#layouts/concentric> ) Desired behaviour This default function would check for a field in node data first, in case it is set from ipycytoscape, before falling back to using node degrees. Minimum steps to reproduce Check issue in ipycytoscape: cytoscape/ipycytoscape#238 (comment) <cytoscape/ipycytoscape#238 (comment)> — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#2945>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAHRO4YEM6YOUN6S4J4KPRTUKRQ3NANCNFSM5HOZRYDQ>.

[shadiakiki1986]

Yes but it's not possible to fix it there because AFAIK ipywidgets doesn't support sending a javascript function to the front-end. OTOH it supports sending a string. So the ipycytoscape issue would be fixed if cytoscape concentric's default function checked a key "concentric" in the data field before falling back to the degree function.

…

On Wed, Nov 10, 2021 at 11:46 AM Max Franz ***@***.***> wrote: This sounds like an ipycytoscape issue. Have you tried posting your issue there? > On Nov 5, 2021, at 6:18 PM, Shadi Akiki ***@***.***> wrote: > > > Current (buggy) behaviour > > concentric layout: node levels are controlled from a javascript function through argument named "concentric" > (docs at: https://js.cytoscape.org/#layouts/concentric < https://js.cytoscape.org/#layouts/concentric> ) > > Desired behaviour > > This default function would check for a field in node data first, in case it is set from ipycytoscape, before falling back to using node degrees. > > Minimum steps to reproduce > > Check issue in ipycytoscape: cytoscape/ipycytoscape#238 (comment) < cytoscape/ipycytoscape#238 (comment) > > — > You are receiving this because you are subscribed to this thread. > Reply to this email directly, view it on GitHub < #2945>, or unsubscribe < https://github.com/notifications/unsubscribe-auth/AAHRO4YEM6YOUN6S4J4KPRTUKRQ3NANCNFSM5HOZRYDQ >. > — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#2945 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACAA5BFB32QTJUZJVETZC3LULKOV3ANCNFSM5HOZRYDQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

[maxkfranz]

Sounds like ipycytoscape should be converting this potential string option to a function on their JS/TS side. Have you posted your issue with ipycytoscape?

…

On Nov 10, 2021, at 11:59, Shadi Akiki ***@***.***> wrote: Yes but it's not possible to fix it there because AFAIK ipywidgets doesn't support sending a javascript function to the front-end. OTOH it supports sending a string. So the ipycytoscape issue would be fixed if cytoscape concentric's default function checked a key "concentric" in the data field before falling back to the degree function. On Wed, Nov 10, 2021 at 11:46 AM Max Franz ***@***.***> wrote: > This sounds like an ipycytoscape issue. Have you tried posting your issue > there? > > > On Nov 5, 2021, at 6:18 PM, Shadi Akiki ***@***.***> wrote: > > > > > > Current (buggy) behaviour > > > > concentric layout: node levels are controlled from a javascript function > through argument named "concentric" > > (docs at: https://js.cytoscape.org/#layouts/concentric < > https://js.cytoscape.org/#layouts/concentric> ) > > > > Desired behaviour > > > > This default function would check for a field in node data first, in > case it is set from ipycytoscape, before falling back to using node degrees. > > > > Minimum steps to reproduce > > > > Check issue in ipycytoscape: cytoscape/ipycytoscape#238 (comment) < > cytoscape/ipycytoscape#238 (comment) > > > > — > > You are receiving this because you are subscribed to this thread. > > Reply to this email directly, view it on GitHub < > #2945>, or unsubscribe < > https://github.com/notifications/unsubscribe-auth/AAHRO4YEM6YOUN6S4J4KPRTUKRQ3NANCNFSM5HOZRYDQ > >. > > > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <#2945 (comment)>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/ACAA5BFB32QTJUZJVETZC3LULKOV3ANCNFSM5HOZRYDQ> > . > Triage notifications on the go with GitHub Mobile for iOS > <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> > or Android > <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. > > — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#2945 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAHRO4YO7VEGP3F65O2NNXTULKQGFANCNFSM5HOZRYDQ>.

[shadiakiki1986]

It could be fixed on ipycytoscape's side in a complex way, or it could be fixed here in cytoscape.js with 1 line of code.
The above PR #2951 does the job.

[stale]

This issue has been automatically marked as stale, because it has not had activity within the past 14 days. It will be closed if no further activity occurs within the next 7 days. If a feature request is important to you, please consider making a pull request. Thank you for your contributions.

[stale]

This issue has been automatically marked as stale, because it has not had activity within the past 14 days. It will be closed if no further activity occurs within the next 7 days. If a feature request is important to you, please consider making a pull request. Thank you for your contributions.