-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug: get an error in pycytominer/__init__.py it was fixed coming back to the previous commit #414
Comments
Hi Paula, Could you let us know what version of pandas you have installed in your virtual environment? This is a future facing change we made to prepare for pandas 3.0.0 but we might need to increase the minimum version of pandas specified for our project to ensure this option is included. CC @d33bs |
Thanks Paula and Ken! I opened a draft PR for a fix for this which should be able to check for the configuration option before attempting to apply it. As Ken mentioned, we should still verify the Pandas version before making these changes (to make sure that the conditional also is appropriate). As an aside, just in case it's helpful, please note that Python 3.8 is reaching end-of-life later this year around October (see here for more). |
thank you, everyone!
|
Thanks @PaulaLlanos ! Based on what you mentioned I looked into Pandas 2.2.0 to find out more about the config option availability. Pandas 2.2.0 I believe makes the the I noticed the logs you shared on opening this issue included a reference to a Python 3.8 environment managed by When you have the chance, could you confirm whether you use |
that is correct, I am using penv to create my environment. I run the command and it look that parallel is using the same dependencies that my environment, see below.
|
Hello again, I just wanted to inform you that a collegue else encountered the same issue on Monday. Thank you for your attention to this matter. I will let you know if someone else is facing the same issue here. |
Thank you @PaulaLlanos for the updates and sorry to hear this is impacting another person. Based on what you've mentioned I've moved #415 out of draft status and will seek review to help avoid this in the future. Something which concerns me about the environment you mention is that Pandas 2.2.0 is incompatible with Python 3.8 (see here)(I gathered Python 3.8 from your original error message posted in this issue). It makes me wonder if the |
I approved @d33bs fix and we'll get that merged as soon as possible. I agree with his assessment that something about your setup means that the dependency versions you reported likely aren't the ones that are being run and causing the error. |
Thanks @kenibrewer ! @PaulaLlanos , a fix has been applied as of f3ce792 which I believe should mitigate the exception you mentioned. Just the same, I recommend double checking your environment to ensure you're using the Python package versions you need for your work (differences from Pandas 1.x.x - 2.x.x could impact data results, for example). |
Oh, thank you all very much. And I'm sorry for the misunderstanding; I thought the error had already been merged on Monday, which is why I mentioned someone else having the same issue. Regarding the dependencies, we typically run those commands as part of our cell painting assay, and we haven't encountered this issue before. However, since you mentioned that some changes are coming in the Python/Pandas version, we will double-check the environment and update accordingly. Thank you again! |
Example code with output
I get an error when I try to use
pycytominer/__init__.py
in the cluster.code:
cd ~/ebs_tmp/${PROJECT_NAME}/workspace/software/pycytominer/
mkdir -p ../../log/${BATCH_ID}/
parallel
--max-procs ${MAXPROCS}
--ungroup
--eta
--joblog ../../log/${BATCH_ID}/collate.log
--results ../../log/${BATCH_ID}/collate
--files
--keep-order
python3 pycytominer/cyto_utils/collate_cmd.py ${BATCH_ID} pycytominer/cyto_utils/database_config/ingest_config.ini {1}
--tmp-dir ~/ebs_tmp
--aws-remote=s3://${BUCKET}/projects/${PROJECT_NAME}/workspace :::: ${PLATES}
error:
Issue description
the error was pasted above
Expected behavior
works deleting just "
__ config__
" from the first line of the file__init__.py
Additional information
this error came from the last commit merged:
62eec0b
The text was updated successfully, but these errors were encountered: