Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FeatureRequest: Minimum cell count per well at some(?) levels #317

Open
1 of 2 tasks
bethac07 opened this issue Aug 16, 2023 · 0 comments
Open
1 of 2 tasks

FeatureRequest: Minimum cell count per well at some(?) levels #317

bethac07 opened this issue Aug 16, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@bethac07
Copy link
Member

Feature type

  • Add new functionality

  • Change existing functionality

General description of the proposed functionality

Sometimes, technical issues on either the wet or dry side lead to wells with very few cells. Since all wells are weighted equally when applying normalization and feature reduction (at least, all wells that pass the criteria, whether that's whole plate or something stricter), this has the potential to decrease the quality of normalization since those wells are highly likely to be, well, weird outliers.

You could in theory imagine this being used with any of the pycytominer functions, and to behave in at least two major ways (drop the row entirely vs just ignore it under certain circumstances) - I think my proposed implementation though would be to add it as a property of the SingleCell class (because if you have a cutoff, you presumably want to use the same cutoff all the time) and then use that to ignore failing wells during the scaler calculation in normalize, the feature removal determination steps in feature_select, and the consensus building step in consensus - aka, the well would remain present (but minimally perturbative) up through stage 4 profiles and then only be fully dropped at stage 5. But willing to consider alternative formulations.

Feature example

Alternative Solutions

No response

Additional information

No response

@bethac07 bethac07 added the enhancement New feature or request label Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant