Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Add miminal test dataset for test_DeepProfiler_processing.py #313

Open
kenibrewer opened this issue Aug 5, 2023 · 1 comment
Open
Labels
bug Something isn't working

Comments

@kenibrewer
Copy link
Member

kenibrewer commented Aug 5, 2023

Example code with output

(pycytominer-py3.10) @kenibrewer ➜ /workspaces/pycytominer (feature/setup-pyproject-toml) $ pytest
===================================================================== test session starts =====================================================================
platform linux -- Python 3.10.12, pytest-7.4.0, pluggy-1.2.0
rootdir: /workspaces/pycytominer
configfile: pyproject.toml
testpaths: tests
collected 147 items                                                                                                                                           

tests/test_aggregate.py .........                                                                                                                       [  6%]
tests/test_annotate.py ....                                                                                                                             [  8%]
tests/test_consensus.py ..                                                                                                                              [ 10%]
tests/test_feature_select.py .........                                                                                                                  [ 16%]
tests/test_normalize.py ...........                                                                                                                     [ 23%]
tests/test_cyto_utils/test_DeepProfiler_processing.py Terminated

Issue description

When run on a machine with small resource requirements (e.g. a Github Codespace with 2 vCPUS and 4 GB of RAM), tests/test_cyto_utils/test_DeepProfiler_processing.py fails with no explanation.

Expected behavior

To enable local debugging on cloud development instances, these tests should be able to run to completion even on machines with smaller resource allocations.

Additional information

A smaller DeepProfiler test dataset would also enable much faster github actions pipeline runtimes as it is by far the longest running test in the pytest suite.

@kenibrewer
Copy link
Member Author

@michaelbornholdt @roshankern I am currently working on re-factoring test_DeepProfiler_processing.py and it is challenging to debug in my usual development environment because of the long runtime and failures dues to insufficient memory. Would one of you be able to help me in creating a minimal set of data files or dataframes that can be used to reduce the runtime of this set of tests?

I think a set of data tests similar to the ones here would also be helpful in making it easier to debug potential future bugs when you don't need to dig through output files that are quite so large.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant