Handle typedefs in ufuncs #6196
Conversation
Extern typedefs get left to the C compiler to sort out since we can't rely on Cython having been told correctly.
Cython/Compiler/UFuncs.py
Outdated
| func_type=PyrexTypes.CFuncType( | ||
| PyrexTypes.c_int_type, | ||
| [PyrexTypes.CFuncTypeArg("types", PyrexTypes.c_char_ptr_type, None), | ||
| PyrexTypes.CFuncTypeArg("arg_count", PyrexTypes.c_py_ssize_t_type, None), | ||
| PyrexTypes.CFuncTypeArg("input_arg_count", PyrexTypes.c_py_ssize_t_type, None)], | ||
| exception_value="-1" | ||
| ), |
There was a problem hiding this comment.
Did you try extracting the function type creation into a constant?
Cython/Utility/UFuncs_C.c
Outdated
| // DW - it's a bit of a shame that this has to be a runtime check since the C compiler does | ||
| // know it. We could make this a compile-time error in C++, but not easily in C. |
There was a problem hiding this comment.
It could potentially figure it out if it inlines the validation function. But how many types do you expect here? One, two, three? Probably rarely more, right? Why not call the validation function multiple times, instead of using a loop? You could also inline the NPY_NOTYPE comparison and keep the helper function only for setting the exception. That should make it easy for the C compiler to discard the calls in the normal cases.
There was a problem hiding this comment.
Ah I think you're slightly misunderstanding the comment.
What I really want is a failure from the C compiler because it already knows that it's used NPY_NOTYPE. I'm not worried about the cost of the validation function. I wish I didn't have to try to import the module to work out that I've got it wrong.
There was a problem hiding this comment.
Something like this?
cython/Cython/Utility/ModuleSetupCode.c
Lines 404 to 407 in bc59042
There was a problem hiding this comment.
Yeah possibly. I'll have another look and see if I can do something like that.
Co-authored-by: scoder <stefan_ml@behnel.de>
Extern typedefs get left to the C compiler to sort out since we can't rely on Cython having been told correctly.
Closes #6161