Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
Originally, I was looking to replace our forked
opn
repo withpatch-package
. In looking at theopn
repo (renamed toopen
), sindresorhus had a note on the repo:That is indeed what we need this for and was not available when this was first coded.
This PR removes the
opn
dep entirely and replaces its use with Electron'sshell.openPath
.Steps to test
Unit test was updated.
I manually tested that the 'View App Data' and the 'Open in Finder' links work still on Mac.
How has the user experience changed?
The user experience should not change.
PR Tasks
cypress-documentation
?type definitions
?