Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove opn dep #29504

Merged
merged 2 commits into from May 10, 2024
Merged

chore: remove opn dep #29504

merged 2 commits into from May 10, 2024

Conversation

jennifer-shehane
Copy link
Member

@jennifer-shehane jennifer-shehane commented May 10, 2024

Additional details

Originally, I was looking to replace our forked opn repo with patch-package. In looking at the opn repo (renamed to open), sindresorhus had a note on the repo:

If you need this for Electron, use shell.openPath() instead.

That is indeed what we need this for and was not available when this was first coded.

This PR removes the opn dep entirely and replaces its use with Electron's shell.openPath.

Steps to test

Unit test was updated.

I manually tested that the 'View App Data' and the 'Open in Finder' links work still on Mac.

Screenshot 2024-05-10 at 2 54 51 PM
Screenshot 2024-05-10 at 2 54 59 PM

How has the user experience changed?

The user experience should not change.

PR Tasks

@jennifer-shehane jennifer-shehane self-assigned this May 10, 2024
@@ -338,13 +337,6 @@ export class SocketBase {
return options.onMocha.apply(options, args)
})

socket.on('open:finder', (p, cb = function () {}) => {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't find this actually emitted anywhere. Maybe I'm wrong in my understanding of this though.

Copy link

cypress bot commented May 10, 2024

2 flaky tests on run #55380 ↗︎

0 4658 951 0 Flakiness 2

Details:

empty commit
Project: cypress Commit: 02e36c687b
Status: Passed Duration: 15:37 💡
Started: May 10, 2024 8:14 PM Ended: May 10, 2024 8:30 PM
Flakiness  cypress/e2e/commands/net_stubbing.cy.ts • 2 flaky tests • 5x-driver-webkit

View Output

Test Artifacts
network stubbing > intercepting request > can delay and throttle a StaticResponse
    </td>
  </tr>
  <tr>
    <td colspan="2">
      <a href="https://cloud.cypress.io/projects/ypt4pf/runs/55380/overview/782fdde4-0f90-4ca5-acd6-3de5f20e24ee?reviewViewBy=FLAKY&utm_source=github&utm_medium=flaky&utm_campaign=view%20test">
        ... > with `resourceType` > can match a proxied image request by resourceType
      </a>
    </td>
    <td>
      
    </td>
  </tr></table>

Review all test suite changes for PR #29504 ↗︎

@jennifer-shehane jennifer-shehane merged commit 223cd35 into develop May 10, 2024
82 of 84 checks passed
@jennifer-shehane jennifer-shehane deleted the remove-opn-dep branch May 10, 2024 21:53
@cypress-bot
Copy link
Contributor

cypress-bot bot commented May 21, 2024

Released in 13.10.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v13.10.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators May 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants