Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempting to Detecting and Crawling for CT Dependencies Inappropriately #28297

Closed
emilyrohrbough opened this issue Nov 9, 2023 · 2 comments
Closed
Labels
stage: needs investigating Someone from Cypress needs to look at this stale no activity on this issue for a long period type: bug

Comments

@emilyrohrbough
Copy link
Member

Current behavior

Opening a project in the launchpad triggers a detectThirdPartyCTFrameworks call for both e2e and component testing when either/or are already configured. It is observed when selecting a testing type and/or later when a browser is selected and launched. This should be happened almost never, (i.e. during component setup). See videos:

Screen.Recording.2023-11-09.at.1.28.01.PM.mov
3rd.party.issue.mov

Desired behavior

The data-context check for CT dependencies should only happen when the both are true:

  1. component testing is not already enabled
  2. the component testing type is selected in the launchpad

Test code to reproduce

Run DEBUG=cypress:scaffold-config:ct-detect-third-party cypress open and select a project and work through launchpad steps. Start with selecting E2E testing and launching the browser.

Cypress Version

13.4.0

Node version

18.5.0

Operating System

MacOS 12.5.1

Debug Logs

No response

Other

No response

@jennifer-shehane jennifer-shehane added type: bug stage: needs investigating Someone from Cypress needs to look at this labels Nov 9, 2023
@cypress-app-bot
Copy link
Collaborator

This issue has not had any activity in 180 days. Cypress evolves quickly and the reported behavior should be tested on the latest version of Cypress to verify the behavior is still occurring. It will be closed in 14 days if no updates are provided.

@cypress-app-bot cypress-app-bot added the stale no activity on this issue for a long period label May 8, 2024
@cypress-app-bot
Copy link
Collaborator

This issue has been closed due to inactivity.

@cypress-app-bot cypress-app-bot closed this as not planned Won't fix, can't repro, duplicate, stale May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stage: needs investigating Someone from Cypress needs to look at this stale no activity on this issue for a long period type: bug
Projects
None yet
Development

No branches or pull requests

3 participants