Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tabs overflow strategy #253

Draft
wants to merge 22 commits into
base: main
Choose a base branch
from
Draft

Tabs overflow strategy #253

wants to merge 22 commits into from

Conversation

elevatebart
Copy link
Collaborator

@elevatebart elevatebart commented Jun 6, 2023 •
edited

closes #252

  • deal with overflow in CSS (just in case)
  • create a dropdown to show the overflowing tabs in with ellipsis
    • Tabs in overflow list never look active
    • When selecting a tab in the drop down, the marker does not move toward ellipsis
    • Do we re-order the tabs when the active tab is in the DD?

@elevatebart elevatebart linked an issue Jun 6, 2023 that may be closed by this pull request
tabs overflow strategy #252
Open
@changeset-bot
Copy link

changeset-bot bot commented Jun 6, 2023 •
edited

🦋 Changeset detected

Latest commit: 42afdcd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@cypress-design/css Minor
@cypress-design/constants-tabs Minor
@cypress-design/react-tabs Minor
@cypress-design/vue-tabs Minor
@cypress-design/rollup-plugin-tailwind-keep Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jun 6, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
cypress-design ✅ Ready (Inspect) Visit Preview Jun 26, 2023 11:15am

@elevatebart elevatebart changed the title 252-tabs-overflow-strategy Tabs overflow strategy Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tabs overflow strategy
1 participant
@elevatebart