Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace the deprecated Buttons with the design system Buttons #189

Open
16 tasks
ryanjwilke opened this issue Apr 17, 2023 · 2 comments
Open
16 tasks

Replace the deprecated Buttons with the design system Buttons #189

ryanjwilke opened this issue Apr 17, 2023 · 2 comments
Assignees

Comments

@ryanjwilke
Copy link
Contributor

ryanjwilke commented Apr 17, 2023

Cypress App

Cypress Cloud

  • Add @deprecated to the old button component(s).
  • Replace the old button component with the new one.
  • Remove any dead code and tests associated with the old button.

Cypress Docs

  • Add @deprecated to the old button component(s).
  • Replace the old button component with the new one.
  • Remove any dead code and tests associated with the old button.

Cypress Learn

  • Add @deprecated to the old button component(s).
  • Replace the old button component with the new one.
  • Remove any dead code and tests associated with the old button.
@cbfrance
Copy link
Contributor

I think a checklist like this will be very useful for our discussion with engineers, and we should probably try to keep it updated as template for any "component rollout."

Trying to think if there are other checklist items ...

  • update any related documentation
  • adjust component props
  • update associated tests (not just removing old ones)
  • Potentially publish updates back to the upstream component (eg. fixes discovered during an initiative)
  • Onboarding to new style eg. Tailwind (or other techniques)
    ... other stuff?

I wonder how much time it will take to do a complete rollout. In this case, the Button component is simple but appears in a lot of places. Other components will probably have tricker implementations.

Thanks for kicking this off @ryanjwilke

@cbfrance
Copy link
Contributor

Another thought, what if design system team went ahead and tagged everything as deprecated? That way the design team could clearly indicate non-conformance and it would remove that checklist item from the engineer's list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants