Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running swc_get_mun_merges() into the console does not return any output #60

Open
andreranza opened this issue Jun 2, 2022 · 3 comments

Comments

@andreranza
Copy link
Member

Running swc_get_mun_merges(2019, canton = "AG") into the console does not return a data.frame or a tibble, conversely to what happens with:

  • tibble::as_tibble(swc_get_mun_merges(2019, canton = "AG"))
  • as.data.frame(swc_get_mun_merges(2019, canton = "AG"))

This behaviour is not aligned with those provided by other functions, such as swc_get_mutations() or swc_get_merger_mapping_table()

@TSchiefer
Copy link
Member

this seems to be because the last statement in the function is an assignment. SHould work if that assignment is removed.
Actually if you assign the result of the function to a variable now it would also work

@andreranza
Copy link
Member Author

andreranza commented Jun 2, 2022

Thanks! Yes, if I assign to a variable it works perfectly. However, I wonder if it would be useful to make this function interactive as the others

@TSchiefer
Copy link
Member

I agree, the assignment in the function should be removed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants