Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dm_from_con() does not default to schema = "public" for Postgres #1440

Open
mgirlich opened this issue Aug 30, 2022 · 2 comments · May be fixed by #1448
Open

dm_from_con() does not default to schema = "public" for Postgres #1440

mgirlich opened this issue Aug 30, 2022 · 2 comments · May be fixed by #1448
Labels
documentation Improvements or additions to documentation
Milestone
learn

Comments

@mgirlich
Copy link
Contributor

Even though it says so in the documentation.

This is due to an early exit

if (is_null(table_names)) {
  return(dm_learned)
}
@krlmlr krlmlr added bug Something isn't working help wanted Happy to review contributions labels Aug 30, 2022
@krlmlr
Copy link
Collaborator

krlmlr commented Aug 30, 2022

Thanks. Would you like to contribute a fix?

@mgirlich mgirlich linked a pull request Sep 2, 2022 that will close this issue
Open
@krlmlr
Copy link
Collaborator

krlmlr commented Aug 14, 2023

I did ask for a fix, now I'm not taking it. Sorry for the noise, it's just way easier to accept the status quo. I'll update the documentation.

@krlmlr krlmlr added documentation Improvements or additions to documentation and removed bug Something isn't working help wanted Happy to review contributions labels Aug 14, 2023
@krlmlr krlmlr added this to the learn milestone Aug 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Milestone
learn
Development

Successfully merging a pull request may close this issue.

Use default schema in dm_learn_from_db() mgirlich/dm
2 participants
@krlmlr @mgirlich