Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reload: allow template variables to change on reload #6045

Open
oliver-sanders opened this issue Apr 2, 2024 · 1 comment
Open

reload: allow template variables to change on reload #6045

oliver-sanders opened this issue Apr 2, 2024 · 1 comment
Milestone

Comments

@oliver-sanders
Copy link
Member

We allow template variables to change when we restart a workflow, but not when we reload one.

The cylc vr command will either:

  • Restart the workflow if it is stopped.
  • Reload the workflow if it is running.

Since cylc restart accepts template variables and cylc reload does not, cylc vr will print a warning if template variables are set, but the workflow is running (since it cannot enact this change).

This restriction is artificial (no fundamental reason why we can't allow template variables to be changed on reload), and appears to have caused a bit of confusion: #5965.

For functionality / consistency, we should support setting template variables with the cylc reload command the same as for cylc play.

@oliver-sanders
Copy link
Member Author

Note, from #5965

Remember to remove the warning from cylc vr when implementing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant