Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing shark teeths for cycleway direction indication #578

Open
shadow-identity opened this issue May 31, 2021 · 5 comments
Open

Missing shark teeths for cycleway direction indication #578

shadow-identity opened this issue May 31, 2021 · 5 comments
Labels
bug Something isn't working

Comments

@shadow-identity
Copy link

shadow-identity commented May 31, 2021

Hey, thank you for the great project!

I just found that in case of

cycleway: opposite_lane
highway: residential
lanes: 1
oneway: yes
oneway:bicycle: no

it renders incorrectly, with cycle lanes on the both sides. While there is only one cycle lane (going opposite). There is no cycle lane in the direction of the line (and it is not described in the tags).

image

The link to the point on map: https://www.cyclosm.org/#map=19/47.06975/15.43023/cyclosm_live

@Phyks
Copy link
Member

Phyks commented May 31, 2021

Hi,

Thanks for the feedback and the issue! cycleway=opposite_lane is somehow an imprecise tagging, as it does not indicate which lane the cycleway is expected to be.

Most of the case it will be on the expected side of driving (right when riding countraflow for most of the world, left for some countries), but there are many exceptions around the globe. Therefore, we decided to render it on both sides of the road to favour more explicit tagging schemes (lateralized).

We used to have "shark teeths" markers for the cycleways to indicate direction. See screenshot in #260 (comment). That way, it was clear for everyone that cycleways on both side of the street were actually going in the same direction and it was giving an indication that these double cycleways were likely artifacts.

Seems we lost it in latest version, we'll have to look into it.

EDIT: I'm editing issue title to reflect this. Please, do comment if you think having shark teeths to disambiguate is not enough.

@Phyks Phyks added the bug Something isn't working label May 31, 2021
@Phyks Phyks changed the title False "Cycle lane on this side of the street" Missing shark teeths for cycleway direction indication May 31, 2021
@Florimondable
Copy link
Member

"shark teeths" has been remoed in an earlier version for optimisation purpose, you were ok with that :)

@Phyks
Copy link
Member

Phyks commented Jun 1, 2021

True, I remember this now, although I cannot find back the PR about this.

I'm still in favor of removing shark teeths for optimization purposes, but looking at it again I think they might be missing in this specific case of non-lateralized cycleways. Maybe it could be worth restoring them only for this specific case?

@shadow-identity
Copy link
Author

Hi Lukas, thank you for your answer. I agree that cycleway=opposite_lane is problematic to determine the exact position of the cycleway if there is no cycleway:lane present.
However, there is another example just near the first one. On the ground this is the same: one-way road with opposite cycleway and without dedicated cycleway in the direction of the main movement of vehicles.
It described as:

cycleway: opposite_lane
cycleway:left: lane
highway: residential
lanes: 1
oneway: yes
oneway:bicycle: no

cycleway: opposite_lane seems redundant for me (since we have cycleway:left: lane set) but still kinda correct. However, it still renders like the road has two lanes.
Maybe in this case we can render the lane from the only one side?
image
https://www.cyclosm.org/#map=19/47.07034/15.43621/cyclosm_live

@Phyks
Copy link
Member

Phyks commented Jun 4, 2021

@shadow-identity I don't understand the tagging scheme in your latest example.

If the cycleway and cycleway:left tags describe the same physical infrastructure, they should IMO be merged into a single cycleway:left=opposite_lane (see https://wiki.openstreetmap.org/wiki/Key:cycleway:left), or even better a cycleway:left=lane; cycleway:left:oneway=-1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants