-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-37: Tool - list imported libraries #38
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one quick review while this is in draft. Thank you for the contribution, it's looking very good!
I would prefer to split the eclipse part into another PR so I can test the new message types (I don't use eclipse for Ghidra development).
@@ -103,7 +101,7 @@ public void sendToReva(RevaMessage message) { | |||
* @throws RevaServerException if there is a problem communicating with ReVa | |||
*/ | |||
private RevaMessage getMessageFromServer() throws RevaServerException { | |||
URI endpoint = revaServerBase.resolve("/project/" + currentProgram.getName() + "/message"); | |||
URI endpoint = revaServerBase.resolve("/project/" + currentProgram.getDomainFile().getName() + "/message"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reminder to update the README.md for this change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I should put this context here too:
I ran into a problem where I had two files in a project, swtor.exe
and swtor.exe_2024xxyy
. I was working in swtor.exe_2024xxyy
and currentProgram.getName()
was returning swtor.exe
, so the Ghidra plugin kept hitting the wrong reverse-engineering-assistant
API endpoint. After exploring the Ghidra API for a while, I eventually found that currentProgram.getDomainFile().getName()
would return the correct swtor.exe_2024xxyy
name.
1903841
to
8f54388
Compare
too out of date now |
No description provided.