Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-37: Tool - list imported libraries #38

Closed
wants to merge 6 commits into from

Conversation

unkmc
Copy link
Contributor

@unkmc unkmc commented Mar 22, 2024

No description provided.

@unkmc unkmc marked this pull request as draft March 22, 2024 16:17
@cyberkaida cyberkaida linked an issue Mar 22, 2024 that may be closed by this pull request
Copy link
Owner

@cyberkaida cyberkaida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one quick review while this is in draft. Thank you for the contribution, it's looking very good!

I would prefer to split the eclipse part into another PR so I can test the new message types (I don't use eclipse for Ghidra development).

ghidra-assistant/.project Outdated Show resolved Hide resolved
@@ -103,7 +101,7 @@ public void sendToReva(RevaMessage message) {
* @throws RevaServerException if there is a problem communicating with ReVa
*/
private RevaMessage getMessageFromServer() throws RevaServerException {
URI endpoint = revaServerBase.resolve("/project/" + currentProgram.getName() + "/message");
URI endpoint = revaServerBase.resolve("/project/" + currentProgram.getDomainFile().getName() + "/message");
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reminder to update the README.md for this change.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I should put this context here too:
I ran into a problem where I had two files in a project, swtor.exe and swtor.exe_2024xxyy. I was working in swtor.exe_2024xxyy and currentProgram.getName() was returning swtor.exe, so the Ghidra plugin kept hitting the wrong reverse-engineering-assistant API endpoint. After exploring the Ghidra API for a while, I eventually found that currentProgram.getDomainFile().getName() would return the correct swtor.exe_2024xxyy name.

@unkmc unkmc marked this pull request as ready for review March 31, 2024 23:54
@unkmc
Copy link
Contributor Author

unkmc commented May 13, 2024

too out of date now

@unkmc unkmc closed this May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Tool to list file's imports
2 participants