Welcome to gltf-test Discussions!

[cx20]

👋 Welcome!

We’re using Discussions as a place to connect with other members of our community. We hope that you:

• Ask questions you’re wondering about.
• Share ideas.
• Engage with other community members.
• Welcome others and are open-minded. Remember that this is a community we
  build together 💪.

To get started, comment below with an introduction of yourself and tell us about what you do with this community.

[elalish]

I'm the maintainer of <model-viewer> and you asked in an earlier thread about our fidelity test suite: #554 (comment)

You can see how the gltf sample viewer was added to our test suite here: https://github.com/google/model-viewer/pull/1962/files#diff-6856cd1835a7703476eaf2fd91803ba39777e755d78d93c5ee484b00892479f0; really the only other addition is here: https://github.com/google/model-viewer/pull/1962/files#diff-298d04f97f7d31ba199f0c8e5fbe54c33f75c1185b01c76c94c5e366d6b13d6d

There are similar PRs adding other renderers like babylon.js and dspbr-pt. We've already set each of these to have identical IBL, tone mapping, exposure, etc. It's not generally very hard to make a new renderer match once they're brought into our framework. I'm happy to help.

[cx20]

I just discussed the following with @emadurandal.

• @emadurandal will send a PR to the fidelity test suite for a sample Rhodonite model-viewer.
• Each gltf-test library sample code is not going to be model viewer code. Each sample code is positioned as a minimum sample that explains the library.
• I plan to add one sample code that uses model-viewer separately from the existing library.

New (modern) efforts will be started with new repositories to avoid repository bloat.
The outline of the new repository is as follows.

• Import glTF-Sample-Models as a submodule
• I think glTF-Sample-Models will refer to the forked version. New models such as unapproved gltf extensions will be added there.
• Install the latest version of the library from npm using package.json
• Sample code is based on TypeScript
• Upload the built file to GitHub Pages

[elalish]

@emadurandal Looking forward to a PR! Please let me know if you have any trouble or need any pointers. Opening a draft PR is often a good way to get help in our repo. Thanks @cx20 for your work in driving glTF rendering convergence. If there's anything we can do to collaborate and help reduce duplicated effort, please let us know.

[emadurandal]

@elalish Thank you, I will.

[emadurandal]

@elalish I’m still working on it. It is taking a bit of time due to camera alignment issues, but I will be able to send you a PR in a little while.

[emadurandal]

@elalish I sent the PR. Please review it: google/model-viewer#3513