Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for WebRTC should be provided for the newest version of the orchestrator #161

Open
jvdrhoof opened this issue Apr 16, 2024 · 2 comments
Assignees

Comments

@jvdrhoof
Copy link
Collaborator

No description provided.

@jvdrhoof jvdrhoof self-assigned this Apr 16, 2024
@jackjansen
Copy link
Collaborator

@jvdrhoof I see that you've updated the new 161 branch to the last state of the master branch just before VR2Gather became a unity package. I.e. to the branch that is nowadays known as historic/framework.

I think it is a good idea to also do the next jump: to the unity package (i.e. to what is currently master). Because the longer we delay this the harder it will become. Mainly because every file in the repo has moved to a different location, and merging changes in the same file in different locations I have found to be rather gruesome (i.e. often git gets confused, in my experience).

I'll try to see whether I can get your current 161 branch running all by myself, then I can after that do the merge of the new master. Otherwise maybe we can find some time next week to do it together.

@jackjansen
Copy link
Collaborator

I had a quick look at the 161 branch.

I think it's best if I first implement #164 before I try merging the current master into 161, because this will mean that all the "webrtc-specific" code will be in the package. If I try merging now it would mean that part of the code, the LoginManager.unity changes, would be in the Samples copied into the VRTApp. That's bound to cause headaches later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants